Skip to content

Commit

Permalink
Reflected review findings
Browse files Browse the repository at this point in the history
  • Loading branch information
Jan Matyas committed Aug 21, 2023
1 parent dff3c4e commit d37baca
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions debug_module.tex
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ \section{Abstract Commands} \label{abstractcommands}
the target and commands succeed, which allows for maximum throughput. If
there is a failure, the interface ensures that no commands execute after
the failing one. To discover which command failed, the debugger has to
look at the state of the DM (e.g.\ contents of \RdmDataZero) or hart (e.g.\
look at the state of the DM (e.g.\ contents of \RdmDataZero) or hart (e.g.\
contents of a register modified by a Program Buffer program) to determine
which one failed.
\end{commentary}
Expand Down Expand Up @@ -470,20 +470,17 @@ \section{Program Buffer} \label{programbuffer}
executes a program that doesn't terminate with an {\tt ebreak} instruction, the
hart will remain in Debug Mode and the debugger will lose control of the hart.

If \FdmAbstractcsProgbufsize is 1 then the following apply:

\begin{enumerate}[nosep]
\item \FdmDmstatusImpebreak must be 1.
\item The debugger must only write a single instruction into the Program Buffer,
regardless of the instruction size. It can be a 32-bit instruction, or
a compressed instruction in the lower 16 bits accompanied by a compressed
\begin{steps}{If \FdmAbstractcsProgbufsize is 1 then the following apply:}
\item \FdmDmstatusImpebreak must be 1.
\item If the debugger writes a compressed instruction into the Program Buffer,
it must be placed into the lower 16 bits and accompanied by a compressed
{\tt nop} in the upper 16 bits.
\end{enumerate}
\end{steps}

\begin{commentary}
This requirement on the debugger for the case of \FdmAbstractcsProgbufsize equal to 1
is to accommodate hardware designs that prefer to stuff instructions directly into
the pipeline when halted, instead of having the Program Buffer exist in the address
This requirement on the debugger for the case of \FdmAbstractcsProgbufsize equal to 1
is to accommodate hardware designs that prefer to stuff instructions directly into
the pipeline when halted, instead of having the Program Buffer exist in the address
space somewhere.
\end{commentary}

Expand Down

0 comments on commit d37baca

Please sign in to comment.