Review address

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
JankariTech · Jun 4, 2024 · 38ab3e7 · 38ab3e7
1 parent bc47cf9
commit 38ab3e7
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/src/views/HomeView.vue b/src/views/HomeView.vue
@@ -126,15 +126,18 @@ const loading = ref(false)
 const filterBy = ref(null)
 const sortBy = ref(null)
 const homeViewMode = ref(null)
-const searchPlaceHolder = ref("anything")
+const searchPlaceHolder = ref("")
 
 onMounted(async () => {
   init()
   tracker.trackPageView()
 })
 
 const getSearchPlaceHolder = computed(() => {
-  return "search by " + searchPlaceHolder.value
+  if (currentRoute.value.params.filterBy) {
+    return "search by " + searchPlaceHolder.value
+  }
+  return "search"
 })
 
 const init = () => {
@@ -176,18 +179,22 @@ const makeSearch = () => {
   searchResultBlog.value = []
   if (filterBy.value) {
     peekData.value.forEach(item => {
-      if (filterBy.value === "tag") {
+      switch (filterBy.value) {
+      case "tag" :
         if (item.tags && item.tags.join(" ").toLowerCase().includes(searchVal)) {
           searchResultBlog.value.push(item)
         }
-      } else if (filterBy.value === "author") {
-        if (item.authorName.toLowerCase().includes(searchVal)) {
+        break
+      case "author" :
+        if (item.tags && item.tags.join(" ").toLowerCase().includes(searchVal)) {
           searchResultBlog.value.push(item)
         }
-      } else {
+        break
+      case "title":
         if (item.title.toLowerCase().includes(searchVal)) {
           searchResultBlog.value.push(item)
         }
+        break
       }
     })
   } else if (sortBy.value) {
@@ -197,6 +204,7 @@ const makeSearch = () => {
       }
     })
   } else {
+    // by default user can search with any of the options (author, title, tags)
     peekData.value.forEach(item => {
       if ((item.tags && item.tags.join(" ").toLowerCase().includes(searchVal)) || (item.authorName.toLowerCase().includes(searchVal)) || (item.title.toLowerCase().includes(searchVal))) {
         searchResultBlog.value.push(item)