Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog] Written a blog in Go series #111

Merged
merged 2 commits into from
Nov 10, 2023
Merged

[blog] Written a blog in Go series #111

merged 2 commits into from
Nov 10, 2023

Conversation

grgprarup
Copy link
Contributor

  • Added a blog on go fundamentals in Journey With Go - A Blog Series

@grgprarup grgprarup self-assigned this Oct 31, 2023
@grgprarup grgprarup requested a review from a team October 31, 2023 09:46
@grgprarup grgprarup added the blog New blog label Oct 31, 2023
@koebel
Copy link
Contributor

koebel commented Nov 6, 2023

This is maybe a more general comment regarding our blog posts: we should make sure to state the source of the header images unless they are our own creations or come from a source that clearly states that no attribution to the creator is requested...

@grgprarup
Copy link
Contributor Author

This is maybe a more general comment regarding our blog posts: we should make sure to state the source of the header images unless they are our own creations or come from a source that clearly states that no attribution to the creator is requested...

The source and credits to the creator of any external images go to the end of my blog.

@koebel
Copy link
Contributor

koebel commented Nov 6, 2023

This is maybe a more general comment regarding our blog posts: we should make sure to state the source of the header images unless they are our own creations or come from a source that clearly states that no attribution to the creator is requested...

The source and credits to the creator of any external images go to the end of my blog.

perfect

saw-jan
saw-jan reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ from my side

koebel
koebel reviewed Nov 6, 2023
View reviewed changes
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
src/assets/JourneyWithGo-ABlogSeries/goFundamentals.md Outdated Show resolved Hide resolved
@grgprarup grgprarup requested a review from koebel November 8, 2023 07:18
@koebel
Copy link
Contributor

koebel commented Nov 9, 2023

Looks good, I like your new example for Runes with Devanagari Script!

saw-jan
saw-jan approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@grgprarup grgprarup merged commit 2c3e584 into master Nov 10, 2023
1 check passed
@grgprarup grgprarup deleted the functions-in-go branch November 10, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebel koebel koebel left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@phil-davis phil-davis Awaiting requested review from phil-davis

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@grgprarup grgprarup

Labels
blog New blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grgprarup @koebel @saw-jan