Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: keycloak #122

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Blog: keycloak #122

merged 3 commits into from
Jun 13, 2024

Conversation

amrita-shrestha
Copy link
Contributor

This PR contain two blog i.e

  • keycloak
  • setup ocis with keycloak

@amrita-shrestha amrita-shrestha self-assigned this Mar 26, 2024
@nabim777 nabim777 added the blog New blog label Mar 26, 2024
@amrita-shrestha amrita-shrestha changed the title Blog on keycloak Blog: keycloak Mar 26, 2024
@amrita-shrestha amrita-shrestha force-pushed the ocis-keycloak branch 4 times, most recently from b898b64 to 45fd8f9 Compare March 26, 2024 09:32
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a look at the first part of the text, good writing style! some minor points are noted in the comments.

src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/keycloak/keycloak.md Outdated Show resolved Hide resolved
@nabim777
Copy link
Member

image

I think it would be better if code is in text format

@nabim777
Copy link
Member

As a reader, I would like to know about the terms like realm, role, role mapping, client etc.
So it would be better to include some description
Or
if the blog becomes too lengthy you can also just include the link

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally:

  • find the official way of writing product names like oCIS and Keycloak and follow the same naming through the complete post
  • use backticks ``` for code, not for general highlighting

src/assets/Keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/ocis-with-keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/ocis-with-keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/ocis-with-keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/ocis-with-keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/ocis-with-keycloak.md Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the ocis-keycloak branch 2 times, most recently from fd19b2b to 0c0a9c8 Compare May 31, 2024 08:47
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first part of the blog post is ready to be published after fixing a minor spelling mistake.

For the second part, there are still some comments given several weeks ago which haven’t been addressed. Since all blog posts end up on our company website without additional iterations as soon as PR is approved and merged, we need to ensure high quality of content and writing. Therefore let’s make sure that our quality standards are met.

src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. There is a tiny suggestion about some English expression, apart of that it looks good to me 👍

koebel
koebel previously approved these changes Jun 4, 2024
@koebel koebel self-requested a review June 4, 2024 09:25
src/assets/Keycloak/Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
src/assets/Keycloak/oCIS-with-Keycloak.md Outdated Show resolved Hide resolved
Co-authored-by: Phil Davis <phil@jankaritech.com>
Co-authored-by: Kathrin Koebel <kathrin@koebel.ch>
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit f1ae77b into master Jun 13, 2024
1 check passed
@phil-davis phil-davis deleted the ocis-keycloak branch June 13, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog New blog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants