New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholders benchmark is broken #66

Open

4 of 5 tasks

JarvisCraft opened this issue Feb 12, 2020 · 0 comments

Assignees

Labels

bug

Owner

JarvisCraft commented Feb 12, 2020 •

edited

Loading

Current implementation of Placholders benchmark is implemented in the wrong way:

Iterations get benchmarked, although they have nothing to do with logic and there is no need to over-complicate benchmarks
Multithreading is enabled which is not needed and causes even more inexact results
Ineffective regex pattern (and maybe algorithm) is used
States have random part which varies between benchmarks (even data length differs)
This benchmark is written by me

JarvisCraft added the bug label

JarvisCraft self-assigned this

JarvisCraft pinned this issue

JarvisCraft added a commit that referenced this issue


          Fix major issues in PlaceholdersBenchmark (resolves #66)

5eab155

JarvisCraft unpinned this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment