Append Discord display name of author when sending message from Discord to game #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that the checkbox says: PR titled using the conventional commits style. I haven't titled my PR according to that style because that's not how I've seen this convention used, but my commits do follow that style. Let me know if you want the PR to be re-titled as well. |
Ah it's okay dw :) I should probably remove that checkbox anyways, doesn't make much sense. |
Jaskowicz1
approved these changes
Oct 24, 2024
|
Looks all good to me! I'll wait for the CI to pass and then I'll merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was kinda annoying that when achievements were off and when relaying a message from Discord to Factorio, we can't see the author of that message on the game since it only says
<server>: .... This PR fixes this issue.How relayed messages looked like before this PR:
After this PR:
