added an empty test

.github/workflows/main.yml

@@ -46,14 +46,16 @@ jobs:
           -Dsonar.projectName=FlickrFinder
           -Dsonar.organization=jeroenbakker-wbd
           -Dsonar.projectKey=JeroenBakker-wbd_FlickrFinder
-          -Dsonar.sources=Data/,Domain/,Presentation/,FlickrFinder/
-          -Dsonar.tests=DataTests/
+          -Dsonar.sources=.
+          -Dsonar.tests=.
+          -Dsonar.test.inclusions=**/Tests/**/*
+          -Dsoner.exclusions=**/Tests/**/*
           -Dsonar.swift.project=FlickrFinder.xcodeproj
           -Dsonar.swift.scheme=FlickrFinder
           -Dsonar.host.url=https://sonarcloud.io
           -Dsonar.token=$SONAR_TOKEN
           -Dsonar.coverageReportPaths=coverage.xml
-          -Dsonar.coverage.exclusions=DataTests/
+          -Dsonar.coverage.exclusions=**/Tests/**/*
           -Dsonar.c.file.suffixes=-
           -Dsonar.cpp.file.suffixes=-
           -Dsonar.objc.file.suffixes=-

Data/.gitignore

@@ -0,0 +1,9 @@
+.DS_Store
+/.build
+/Packages
+/*.xcodeproj
+xcuserdata/
+DerivedData/
+.swiftpm/config/registries.json
+.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
+.netrc

Data/.swiftpm/xcode/package.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>

Data/Package.swift

@@ -0,0 +1,38 @@
+// swift-tools-version: 5.7
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
+    name: "Data",
+    platforms: [
+        .iOS(.v16),
+        .tvOS(.v16),
+        .watchOS(.v9),
+    ],
+    products: [
+        // Products define the executables and libraries a package produces, and make them visible to other packages.
+        .library(
+            name: "Data",
+            targets: ["Data"]),
+    ],
+    dependencies: [
+        .package(path: "../Domain"),
+        .package(url: "https://github.com/hmlongco/Factory", from: "1.0.0"),
+    ],
+    targets: [
+        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
+        // Targets can depend on other targets in this package, and on products in packages this package depends on.
+        .target(
+            name: "Data",
+            dependencies: [
+                .product(name: "Domain", package: "Domain"),
+            ]),
+        .testTarget(
+            name: "DataTests",
+            dependencies: [
+                "Data",
+                .product(name: "Factory", package: "Factory")
+            ]),
+    ]
+)

Data/README.md

@@ -0,0 +1,3 @@
+# DataPackage
+
+A description of this package.

Data/Injection/DataInjection.swift → Data/Sources/Data/Injection/DataInjection.swift

@@ -7,6 +7,7 @@
 
 import Domain
 import Factory
+import Foundation
 
 // MARK: - Singletons
 extension Container: AutoRegistering {

Data/Usecases/API/APIService.swift → Data/Sources/Data/Usecases/API/APIService.swift

@@ -7,6 +7,7 @@
 
 import Domain
 import Factory
+import Foundation
 
 struct APIService: APIWorker {
 
@@ -43,4 +44,8 @@ struct APIService: APIWorker {
             throw NetworkError.statusCode(httpUrlResponse.statusCode)
         }
     }
+
+    func anEmptyTestWhichShouldBeReportedAsACodeSmell() {
+
+    }
 }

Data/Usecases/SearchPhotos/Models/FlickrSearchPhotoError.swift → Data/Sources/Data/Usecases/SearchPhotos/Models/FlickrSearchPhotoError.swift

@@ -7,7 +7,7 @@
 
 import Foundation
 
-enum FlickrSearchPhotoError: Error {
+enum FlickrSearchPhotoError: Error, Equatable {
     case api(FlickrAPIError)
     case tooManyTags
     case unknownUser

Data/Usecases/SearchPhotos/SearchPhotosService.swift → Data/Sources/Data/Usecases/SearchPhotos/SearchPhotosService.swift

@@ -7,6 +7,7 @@
 
 import Domain
 import Factory
+import Foundation
 
 struct SearchPhotosService: SearchPhotosWorker {
 

Data/Tests/DataTests/Usecases/SearchPhotos/FlickrSearchPhotoErrorTests.swift

@@ -0,0 +1,44 @@
+//
+//  Created by Jeroen Bakker on 28/08/2023.
+//  Copyright (c) 2023 Bleacher Report. All rights reserved.
+//
+
+import XCTest
+@testable import Data
+
+final class FlickrSearchPhotoErrorTests: XCTestCase {
+
+    func test_init_onUnsupportedInput_shouldReturnAPIEnum() throws {
+        // given
+        let input = 0
+
+        // when
+        let result = FlickrSearchPhotoError(rawValue: input)
+
+        // then
+        if case .api(let flickrAPIError) = result {
+            XCTAssertEqual(.unknown, flickrAPIError)
+        } else {
+            XCTFail()
+        }
+    }
+
+    func test_Init_onSupportedInputs_shouldReturnEnum() throws {
+        // given
+        let inputs = [1, 2, 3, 4, 5]
+        let expectedResults: [FlickrSearchPhotoError] = [
+            .tooManyTags,
+            .unknownUser,
+            .parameterlessSearchesDisabled,
+            .noPermission,
+            .userDeleted
+        ]
+
+        for (index, input) in inputs.enumerated() {
+            // when
+            let result = FlickrSearchPhotoError(rawValue: input)
+            // then
+            XCTAssertEqual(expectedResults[index], result)
+        }
+    }
+}

Domain/.gitignore

@@ -0,0 +1,9 @@
+.DS_Store
+/.build
+/Packages
+/*.xcodeproj
+xcuserdata/
+DerivedData/
+.swiftpm/config/registries.json
+.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
+.netrc

Domain/.swiftpm/xcode/package.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>IDEDidComputeMac32BitWarning</key>
+	<true/>
+</dict>
+</plist>

Domain/Package.swift

@@ -0,0 +1,35 @@
+// swift-tools-version: 5.7
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
+    name: "Domain",
+    platforms: [
+        .iOS(.v16),
+        .tvOS(.v16),
+        .watchOS(.v9),
+    ],
+    products: [
+        // Products define the executables and libraries a package produces, and make them visible to other packages.
+        .library(
+            name: "Domain",
+            targets: ["Domain"]),
+    ],
+    dependencies: [
+        // Dependencies declare other packages that this package depends on.
+         .package(url: "https://github.com/hmlongco/Factory", from: "1.0.0"),
+    ],
+    targets: [
+        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
+        // Targets can depend on other targets in this package, and on products in packages this package depends on.
+        .target(
+            name: "Domain",
+            dependencies: [
+                .product(name: "Factory", package: "Factory")
+            ]),
+        .testTarget(
+            name: "DomainTests",
+            dependencies: ["Domain"]),
+    ]
+)

Domain/README.md

@@ -0,0 +1,3 @@
+# DomainPackage
+
+A description of this package.

Domain/Tests/DomainTests/DomainPackageTests.swift

@@ -0,0 +1,11 @@
+import XCTest
+@testable import Domain
+
+final class DomainPackageTests: XCTestCase {
+    func testExample() throws {
+        // This is an example of a functional test case.
+        // Use XCTAssert and related functions to verify your tests produce the correct
+        // results.
+//        XCTAssertEqual(Domain().text, "Hello, World!")
+    }
+}