Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make delay before uploading files configurable #142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lensvol
Copy link
Collaborator

@lensvol lensvol commented Feb 17, 2021

Sometimes MicroPython firmware can send a lot of additional information on startup (e.g. esp32-idf3-20200902-v1.13.bin). Such behavior breaks microupload.py since the hardcoded half-second is not enough.

This PR adds an additional option to the Settings pane that lets you modify board detection delay.

Copy link
Contributor

@vlasovskikh vlasovskikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I'd actually prefer a different approach easier for the users. It would be cooler to make the delay auto-adjustable based on errors in communicating with the device, so that the user doesn't have to adjust it manually. You can start with 0.5, then on error re-retry with some delay, then do it again a few times.

@AnAvgGuy
Copy link

AnAvgGuy commented Jan 8, 2022

Sometimes MicroPython firmware can send a lot of additional information on startup (e.g. esp32-idf3-20200902-v1.13.bin). Such behavior breaks microupload.py since the hardcoded half-second is not enough.

This PR adds an additional option to the Settings pane that lets you modify board detection delay.

Where is the microupload.py file? Cant seem to find it

@valeyard
Copy link

valeyard commented Jun 3, 2024

2 years on and this is still an issue, I just had to go into the micropython.py file and change the sleep value which really isn't ideal since this script is not version controlled and is just part of 3rd party libraries...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants