Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental VLLM Integration #174

Merged
merged 8 commits into from
Oct 29, 2023
Merged

Experimental VLLM Integration #174

merged 8 commits into from
Oct 29, 2023

Conversation

JettChenT
Copy link
Owner

No description provided.

@JettChenT JettChenT merged commit 6d2d491 into master Oct 29, 2023
2 checks passed
@sweep-ai
Copy link

sweep-ai bot commented Oct 29, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2023
View reviewed changes
sfw/places_mod.py

# load the model
self.features_blobs = []
self.model = load_model(lambda module,input,output: self.hook_feature(module,input,output))
self.model = load_model(
lambda module, input, output: self.hook_feature(module, input, output)

Check notice

Code scanning / CodeQL

Unnecessary lambda Note

This 'lambda' is just a simple wrapper around a callable object. Use that object directly.
sfw/rtsp.py
@@ -2,9 +2,10 @@
import cv2
import time

def attack(ipaddr, port=554, dictionary = './rtsp_dict/tries.txt'):

def attack(ipaddr, port=554, dictionary="./rtsp_dict/tries.txt"):

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
sfw/streaming.py
def __getitem__(self, key: CameraEntry|int) -> None|Image.Image:
if type(key) == int:

def __getitem__(self, key: CameraEntry | int) -> None | Image.Image:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
sfw/cli.py
if store:
json.dump(res, open(store, 'r'))
json.dump(res, open(store, "r"))

Check warning

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.
sfw/cli.py
)
if store:
json.dump(res, open(store, 'r'))
json.dump(res, open(store, "r"))

Check warning

Code scanning / CodeQL

File is not always closed Warning

File is opened but is not closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JettChenT