chore(client): migrate add access key dialog to lit #2134
Conversation
daniellacosse
changed the title
| @@ -27,6 +27,30 @@ | |||
| "description": "The title of a page giving details about the app.", | |||
| "message": "About" | |||
| }, | |||
| "add_access_key_dialog_header": { | |||
There was a problem hiding this comment.
@sbruens remind me, do I need to update en.json?
There was a problem hiding this comment.
No. That's a translation file. You only need to update the original, which is this file.
There was a problem hiding this comment.
Ah, but when i don't fill out the en.json it looks like this:
There was a problem hiding this comment.
That's good. It shows you the translations are not done.
| @@ -27,6 +27,39 @@ | |||
| "description": "The title of a page giving details about the app.", | |||
| "message": "About" | |||
| }, | |||
| "add_access_key_dialog_header": { | |||
| "description": "The title of a dialog box that prompts the user to add a new access key.", | |||
| "message": "Add VPN access key" | |||
There was a problem hiding this comment.
Let's go back to the original "Add access key".
"VPN" is confusing, and some consider it not a VPN (we don't give access to a private network). Also, we are moving towards a world where we may include proxyless. We are adding a strategy, not a server of service, hence keeping "access key".
| "description": "An error message shown when the user tries to add a server with an invalid access key.", | ||
| "message": "Invalid access key." | ||
| }, | ||
| "add_access_key_dialog_cancel": { |
There was a problem hiding this comment.
Don't we have those messages already? Why change them?
| }, | ||
| "add_access_key_dialog_confirm": { | ||
| "desciption": "The text on a button to confirm the adding of an access key.", | ||
| "message": "Confirm" |
There was a problem hiding this comment.
The existing "Add Server" is superior, since it makes the action explicit, versus a generic "Confirm". Please revert or change to "Add Key". I think we never changed from "Server" because of the need to translate...
Screen.Recording.2024-08-22.at.7.29.37.PM.mov