Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly format usage data #2148

Closed
wants to merge 5 commits into from
Closed

Conversation

sabify
Copy link

@sabify sabify commented Aug 24, 2024

No description provided.

@sabify sabify requested a review from a team as a code owner August 24, 2024 19:19
@sbruens
Copy link
Contributor

sbruens commented Aug 26, 2024

Thank you for your contribution @sabify, we are always happy for people to volunteer their time to the Outline ecosystem!

Unfortunately, we won't be able to accept this PR. The format we use follows the International System of Units (SI) when displaying gigabyte (GB), i.e. 10^9 bytes. I don't think we'll change that anytime soon.

I understand this has been a source of confusion since we have had bug reports about this issue in the past, so I created #2150 to address it in the UI with a tooltip, which we hope to prioritize soon, but we're open to other suggestions as well.

@sbruens sbruens closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants