Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/ios): filter AppKitIntegration framework to maccatalyst #2251

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 18, 2024

This platform filter was accidentally removed in #2090 and causing asset validation issues for the iOS app:

Asset validation failed
This bundle is invalid. Applications built for more than one architecture require an iOS Deployment Target of 3.0 or later. (ID: ec5bf398-a85e-4069-a03f-9b7cb51b40c4)

Asset validation failed
Unsupported Architectures. The executable for Outline.app/Frameworks/AppKitIntegration.framework contains unsupported architectures '[x86_64]'. (ID: 72745965-6014-4983-9631-028f7a57c917)

Asset validation failed
Invalid bundle structure. The “Outline.app/Frameworks/AppKitIntegration.framework/Versions/A/AppKitIntegration” binary file is not permitted. Your app cannot contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. For details, visit: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle (ID: a4bf6667-5817-46c6-b175-9d4dbc889d5f)

Asset validation failed
Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle Outline.app/Frameworks/AppKitIntegration.framework is required. (ID: 446cd137-ed5d-4739-8b15-cd2148017874)

Asset validation failed
Invalid Segment Alignment. The app binary at 'Outline.app/Frameworks/AppKitIntegration.framework/AppKitIntegration' does not have proper segment alignment. Try rebuilding the app with the latest Xcode version. (ID: 25fe97fe-0caa-4818-b300-ac123462192c)

Asset validation failed
Invalid Segment Alignment. The app binary at 'Outline.app/Frameworks/AppKitIntegration.framework/Versions/A/AppKitIntegration' does not have proper segment alignment. Try rebuilding the app with the latest Xcode version. (ID: b3588581-58e7-4822-8b55-e380dfa2bc78)

Asset validation failed
The binary is invalid. The encryption info in the LC_ENCRYPTION_INFO load command is either missing or invalid, or the binary is already encrypted. This binary does not seem to have been built with Apple's linker. (ID: b4c38d6e-aaaa-45f4-9882-0a09c501a1ad)

Asset validation failed
Invalid Bundle. The bundle Outline.app/Frameworks/AppKitIntegration.framework does not support the minimum OS Version specified in the Info.plist. (ID: 2c802eb5-9e91-4a4e-87c6-c1e114473182)

@sbruens sbruens marked this pull request as ready for review October 18, 2024 17:17
@sbruens sbruens requested a review from a team as a code owner October 18, 2024 17:17
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can try the release script on this branch.

@sbruens sbruens merged commit 397d368 into master Oct 18, 2024
23 checks passed
@sbruens sbruens deleted the sbruens/ios-release branch October 18, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants