fix(client): increase padding to account for safe area #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakovmanshin
commented
Oct 18, 2024
| @@ -87,7 +87,7 @@ export class ServerList extends LitElement { | |||
| } | |||
| footer { | |||
| border-top: 1px solid rgba(0, 0, 0, 0.08); | |||
| padding: 24px 0 16px; | |||
| padding: 24px 0 max(16px, env(safe-area-inset-bottom)); | |||
There was a problem hiding this comment.
max() was added in Chrome 79. Not sure if it covers every supported OS version, but since the related min() function is already used in the project, I figured it’s fine to use max() here.
yakovmanshin
changed the title
|
@daniellacosse I renamed the PR so the name check doesn’t fail. Could you please approve the workflow? Thank you! |
* Updated zero state’s footer’s bottom padding to include safe area
yakovmanshin
force-pushed
the
zero-state-footer-padding
branch
from
62c9484
to
e2ccbf4
Compare
yakovmanshin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before & After (iOS 18)