-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create SOCKS5 StreamDialer #44
Conversation
transport/socks5/packet_dialer.go
Outdated
"net" | ||
|
||
"github.com/Jigsaw-Code/outline-sdk/transport" | ||
"golang.org/x/net/proxy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh it seems like the proxy library doesn't currently support UDP, so it may make sense to revert this for now: https://cs.opensource.google/go/x/net/+/master:internal/socks/socks.go;l=233;drc=126a5f3b343c940b1ce677f43b138556311b0999
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we support one more protocol now!
Please take another look. I added unit tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good, but it is failing.
}() | ||
|
||
// Client | ||
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit it seems we don't need put to client logic in the go func
, because server is already running concurrently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clearer to have the client and server well delineated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fixed!
}() | ||
|
||
// Client | ||
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's clearer to have the client and server well delineated.
Needs test