Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move outline-ss-server to cmd/ and hide code #136

Merged
merged 8 commits into from
Dec 8, 2022
Merged

refactor: move outline-ss-server to cmd/ and hide code #136

merged 8 commits into from
Dec 8, 2022

Conversation

fortuna
Copy link

@fortuna fortuna commented Dec 8, 2022 •
edited
Loading

  • Moves the binary to the standard cmd directory, and paves the way for having more binaries, like a socks2shadowsocks client.
  • Hides internal code to prevent external dependencies.

@fortuna fortuna requested a review from jyyi1 December 8, 2022 05:49
@fortuna fortuna requested a review from a team as a code owner December 8, 2022 05:49
@fortuna fortuna self-assigned this Dec 8, 2022
@fortuna fortuna changed the title chore: move outline-ss-server to cmd/ refactor: move outline-ss-server to cmd/ Dec 8, 2022
@fortuna fortuna changed the title refactor: move outline-ss-server to cmd/ refactor: move outline-ss-server to cmd/ and hide code Dec 8, 2022
jyyi1
jyyi1 approved these changes Dec 8, 2022
View reviewed changes
Copy link

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the structure is clearer now.

@fortuna fortuna merged commit 2f04edc into master Dec 8, 2022
@fortuna fortuna mentioned this pull request Mar 17, 2023
Merged
@fortuna fortuna deleted the fortuna-refactor branch January 10, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees

@fortuna fortuna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @jyyi1