-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add support for chat and instruct model types #1131
Merged
chakravarthik27
merged 12 commits into
release/2.5.0
from
feature/add-support-for-chat-and-instruct-model-types
Oct 21, 2024
Merged
Feature/add support for chat and instruct model types #1131
chakravarthik27
merged 12 commits into
release/2.5.0
from
feature/add-support-for-chat-and-instruct-model-types
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hance prediction handling for chat models, and update prompt management for flexibility.
…d HuggingFacePipeline classes
…fig class and remove unnecessary code in HuggingFacePipeline class
Prikshit7766
approved these changes
Oct 21, 2024
chakravarthik27
deleted the
feature/add-support-for-chat-and-instruct-model-types
branch
December 24, 2024 16:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings several enhancements and bug fixes to the
langtest
module, focusing on model configuration and handling. The key updates include:Model Configuration and Handling Improvements:
Configuration Types Added:
DatasetConfig
andModelConfig
types to define configurations for datasets and models inlangtest/types.py
.Class Initializer Changes:
Harness
class initializer to acceptModelConfig
andDatasetConfig
types for themodel
anddata
parameters.__init__
method inHarness
to handle themodel_type
attribute.Model Loading Enhancements:
load_model
method inllm_modelhandler.py
to support themodel_type
parameter, including chat models.transformers_modelhandler.py
to managemodel_type
in theload_model
andpredict
methods, with added support for chat models.Utility and Miscellaneous Updates:
Utility Improvements:
CHAT_MODEL_CLASSES
mapping inutils.py
for associating hub names with chat model classes.config_utils.py
forDEFAULTS_CONFIG
.Prompt Handling Updates:
prompts.py
to support prompt retrieval for the "transformers" hub.These changes enhance the flexibility and robustness of the
langtest
module, making it easier to work with various model configurations and types.