Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renamed all env vars to drop ARK prefix #17

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Johnny-Knighten
Copy link
Owner

BREAKING CHANGE: every existing container deployment will need their env var names updated

Description

Include a summary of the change and which issue is fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.

The current environment variable naming convention with the ARK_ prefix was resulting in overly verbose files. The ARK_ prefix was dropped altogether.

Issue/Ticket Number and Link (If Relevant)

No associated issue or ticket.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Entire test suite were rewrote and ran to verify env var name changes

Checklist:

Before you submit your Pull Request, make sure you have done the following:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate any existing code (including PRs).
  • I have tested my code and made sure it works as expected.
  • My change requires a change to the documentation, and I have updated the documentation accordingly.
  • I have provided a detailed description of my changes above.
  • I have linked any related issues or PRs in my changes.

BREAKING CHANGE: every existing container deployment will need their env var names updated
@Johnny-Knighten Johnny-Knighten merged commit b7e1359 into next Nov 27, 2023
2 checks passed
@Johnny-Knighten Johnny-Knighten deleted the refactor/revise-env-var-names branch November 27, 2023 22:51
Copy link

🎉 This PR is included in version 2.0.0-next.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant