removed unneeded access token

JohnnyTheTank · Jun 1, 2016 · 5e8ec22 · 5e8ec22
1 parent 443a16a
commit 5e8ec22
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 25 deletions.
diff --git a/README.md b/README.md
@@ -34,7 +34,7 @@ Author: Jonathan Hornung ([JohnnyTheTank](https://github.com/JohnnyTheTank))
 ```js
 githubFactory.getUser({
     user:"<USERNAME_NAME>",
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {
@@ -47,7 +47,7 @@ githubFactory.getUser({
 githubFactory.getRepoByUserAndName({
     user:"<USER_NAME>",
     repo:"<REPO_NAME>",
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {
@@ -63,7 +63,7 @@ githubFactory.getReposByName({
     sort:"<SORT_STRING>", // (optional) 'stars', 'forks', or 'updated'
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {
@@ -78,7 +78,7 @@ githubFactory.getReposByUser({
     sort:"<SORT_STRING>", // (optional) 'stars', 'forks', or 'updated'
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {
@@ -95,7 +95,7 @@ githubFactory.getEventsFromRepoByUserAndName({
     sort:"<SORT_STRING>", // (optional)
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {
@@ -110,7 +110,7 @@ githubFactory.getEventsByUser({
     sort:"<SORT_STRING>", // (optional)
     order:"<SORT_ORDER>", // (optional) 'desc', 'asc'
     per_page:"<ITEMS_PER_PAGE>", // (optional) valid values: 1-100 | default: 30
-    access_token:"<ACCESS_TOKEN>"
+    access_token:"<ACCESS_TOKEN>" // (optional)
 }).then(function(_data){
     //on success
 }).catch(function (_data) {

diff --git a/bower.json b/bower.json
@@ -1,7 +1,7 @@
 {
   "name": "angular-github-api-factory",
   "description": "angularjs factory for github json rest api requests",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "main": "dist/angular-github-api-factory.js",
   "authors": [
     "Jonathan Hornung"

diff --git a/demo/js/app.js b/demo/js/app.js
@@ -1,35 +1,32 @@
 var app = angular.module("app", ['jtt_github']);
 app.controller('controller', ['$scope', 'githubFactory', function($scope, githubFactory) {
 
-    var _access_token = '<YOUR_GITHUB_ACCESS_TOKEN>';
-
     githubFactory.getUser({
         user:"xremix",
-        access_token:_access_token
     }).then(function(_data){
         console.info("user", _data);
     });
 
+
     githubFactory.getReposByUser({
         user:"JohnnyTheTank",
         per_page: 100,
-        access_token:_access_token
     }).success(function(_data){
         console.info("repos by user", _data);
     });
 
+
     githubFactory.getReposByName({
         q:"apiNG-plugin",
         per_page: 20,
-        access_token:_access_token
     }).then(function(_data){
         console.info("repos by name", _data);
     });
 
+
     githubFactory.getEventsByUser({
         user:"xremix",
         per_page: 20,
-        access_token:_access_token
     }).then(function(_data){
         console.info("events by user", _data);
     });
@@ -38,7 +35,6 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
         user:"JohnnyTheTank",
         repo:"apiNG",
         per_page: 100,
-        access_token:_access_token
     }).then(function(_data){
         console.info("events from repo by user and name", _data);
     });
@@ -47,7 +43,6 @@ app.controller('controller', ['$scope', 'githubFactory', function($scope, github
         user:"xremix",
         repo:"xGallerify",
         per_page: 20,
-        access_token:_access_token
     }).then(function(_data){
         console.info("repo by user and name", _data);
     });

diff --git a/dist/angular-github-api-factory.js b/dist/angular-github-api-factory.js
@@ -1,6 +1,6 @@
 /**
     @name: angular-github-api-factory 
-    @version: 0.5.0 (17-02-2016) 
+    @version: 0.5.1 (01-06-2016) 
     @author: Jonathan Hornung 
     @url: https://github.com/JohnnyTheTank/angular-github-api-factory#readme 
     @license: MIT
@@ -86,16 +86,18 @@ angular.module("jtt_github", [])
 
         this.getNew = function (_type, _params) {
             var githubSearchData = {
-                object: {
-                    access_token: _params.access_token,
-                },
+                object: {},
                 url: "",
             };
 
             if (angular.isDefined(_params.per_page)) {
                 githubSearchData.object.per_page = _params.per_page;
             }
 
+            if (angular.isDefined(_params.access_token)) {
+                githubSearchData.object.access_token = _params.access_token;
+            }
+
             switch (_type) {
                 case "user":
                     githubSearchData.object.per_page = undefined;

diff --git a/dist/angular-github-api-factory.min.js b/dist/angular-github-api-factory.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-github-api-factory",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "angularjs factory for github json rest api requests",
   "main": "dist/angular-github-api-factory.js",
   "scripts": {

diff --git a/src/angular-github-api-factory.js b/src/angular-github-api-factory.js
@@ -79,16 +79,18 @@ angular.module("jtt_github", [])
 
         this.getNew = function (_type, _params) {
             var githubSearchData = {
-                object: {
-                    access_token: _params.access_token,
-                },
+                object: {},
                 url: "",
             };
 
             if (angular.isDefined(_params.per_page)) {
                 githubSearchData.object.per_page = _params.per_page;
             }
 
+            if (angular.isDefined(_params.access_token)) {
+                githubSearchData.object.access_token = _params.access_token;
+            }
+
             switch (_type) {
                 case "user":
                     githubSearchData.object.per_page = undefined;