Skip to content

Commit

Permalink
Small Commit!
Browse files Browse the repository at this point in the history
fixed sustain notes not having their color updated if the change character event is called whilst Char-Based colors were on

renderlol.bat will now ask you for the video framerate.
  • Loading branch information
JordanSantiagoYT committed Nov 7, 2024
1 parent 5543c84 commit d02176e
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 12 deletions.
6 changes: 5 additions & 1 deletion assets/preload/gameRenders/renderlol.bat
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ echo.
echo what would you like to name your rendered video?
set /p "renderName="

echo.
echo what is the framerate of your images/video?
set /p "vidFPS="

echo.
echo lastly, are you rendering your video in a lossless format? (y/n, default n, makes the renderer find pngs instead of jpgs)
set /p "useLossless="
Expand All @@ -25,6 +29,6 @@ echo.
echo Starting...
echo.

ffmpeg -r 60 -i "%~dp0%renderFolder%\%%07d.%fExt%" "%renderName%.mp4"
ffmpeg -r %vidFPS% -i "%~dp0%renderFolder%\%%07d.%fExt%" "%renderName%.mp4"

pause
2 changes: 1 addition & 1 deletion source/MusicBeatState.hx
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class MusicBeatState extends FlxUIState

override function update(elapsed:Float)
{
if (oldStep != curStep) oldStep = curStep;
oldStep = curStep;

updateCurStep();
updateBeat();
Expand Down
22 changes: 12 additions & 10 deletions source/PlayState.hx
Original file line number Diff line number Diff line change
Expand Up @@ -3097,11 +3097,12 @@ class PlayState extends MusicBeatState

if (ClientPrefs.noteColorStyle == 'Char-Based')
{
for (note in notes){
if (note == null)
continue;
note.updateRGBColors();
}
for (group in [notes, sustainNotes])
for (note in group){
if (note == null)
continue;
if (ClientPrefs.enableColorShader) note.updateRGBColors();
}
}

unspawnNotes.sort(sortByTime);
Expand Down Expand Up @@ -4670,11 +4671,12 @@ class PlayState extends MusicBeatState
}
if (ClientPrefs.noteColorStyle == 'Char-Based')
{
for (note in notes){
if (note == null)
continue;
if (ClientPrefs.enableColorShader) note.updateRGBColors();
}
for (group in [notes, sustainNotes])
for (note in group){
if (note == null)
continue;
if (ClientPrefs.enableColorShader) note.updateRGBColors();
}
}
}

Expand Down

0 comments on commit d02176e

Please sign in to comment.