Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA testing with mypy #739

Merged
merged 14 commits into from
Dec 29, 2023
Merged

QA testing with mypy #739

merged 14 commits into from
Dec 29, 2023

Conversation

Josverl
Copy link
Owner

@Josverl Josverl commented Dec 29, 2023

This PR adds mypy to the QA test matrix.

It uses the same typecheck framework setup for pyright in order to be able to compare the results side by side.

As the output formats are very different , the mypy output is converted into the same json schema as used by pyright so that the same filtering logic can be used to remove false positives using : # stubs-ignore: linter == "mypy" and similar expressions.

A few test snippets have been adjusted wrt to syntax ( # type ignore # with some other comments) that are not accepted by mypy
and a few improvent to the snippets have been made where mypy has stricter pre-conditions.

Signed-off-by: Jos Verlinde jos_verlinde@hotmail.com

Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@Josverl Josverl merged commit cc3ea43 into main Dec 29, 2023
1 of 2 checks passed
@Josverl Josverl deleted the QA_try_mypy branch December 29, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant