Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators list filter search #4404

Merged
merged 29 commits into from
Aug 7, 2023
Merged

Validators list filter search #4404

merged 29 commits into from
Aug 7, 2023

Conversation

eshark9312
Copy link
Contributor

@eshark9312 eshark9312 commented Jun 2, 2023 •
edited
Loading

Resolves #4328
Resolves #4329
Add the components for validators list and filter including search box.

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Aug 7, 2023 11:57am
pioneer-2 ✅ Ready (Inspect) Visit Preview Aug 7, 2023 11:57am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Aug 7, 2023 11:57am

@eshark9312 eshark9312 marked this pull request as ready for review June 7, 2023 09:15
@chrlschwb chrlschwb added jsg-code-review community-dev issue suitable for community-dev pipeline labels Jun 8, 2023
@eshark9312 eshark9312 force-pushed the validators-list-filter-search branch from 14bb89d to 0b36c74 Compare June 9, 2023 05:09
@eshark9312 eshark9312 mentioned this pull request Jun 9, 2023
Merged
@thesan
Copy link
Member

thesan commented Jun 13, 2023

@eshark9312 same as #4418 (comment) because this PR is based on your #4375, I'm converting it to draft for the moment.

@thesan thesan marked this pull request as draft June 13, 2023 14:00
@eshark9312 eshark9312 force-pushed the validators-list-filter-search branch from 92a65f9 to 3f0a07f Compare July 24, 2023 09:55
@eshark9312 eshark9312 force-pushed the validators-list-filter-search branch from 3f0a07f to 5d8f8ce Compare July 25, 2023 15:48
@thesan
Copy link
Member

thesan commented Aug 4, 2023

Also on the APR: #4404 (comment)

@thesan
Copy link
Member

thesan commented Aug 4, 2023

I'll take a deeper look at the "started on" problem next week.

thesan
thesan requested changes Aug 7, 2023
View reviewed changes
packages/ui/src/validators/hooks/useValidatorsList.tsx Outdated Show resolved Hide resolved
packages/ui/src/validators/types/Validator.ts Outdated Show resolved Hide resolved
@eshark9312 eshark9312 force-pushed the validators-list-filter-search branch from 55f6248 to 856bfce Compare August 7, 2023 11:41
@eshark9312 eshark9312 force-pushed the validators-list-filter-search branch from 856bfce to 0bd4e2f Compare August 7, 2023 11:51
@eshark9312 eshark9312 requested a review from thesan August 7, 2023 12:57
thesan
thesan approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@thesan thesan merged commit 3d2099e into Joystream:dev Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesan thesan thesan approved these changes

@chrlschwb chrlschwb chrlschwb approved these changes

Assignees
No one assigned
Labels
community-dev issue suitable for community-dev pipeline jsg-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validators list - Search Validators list - Filters
3 participants
@eshark9312 @thesan @chrlschwb