Validators list page validator card #4419
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eshark9312
force-pushed
the
validators-list-page-validatorCard
branch
from
2747466
to
b949609
Compare
chrlschwb
added
community-dev
|
@chrlschwb this PR is not ready for review it includes a lot of changes from #4404 because git isn't able to differentiate identify them in the "squash and merge" commit (so they show as conflicts). @eshark9312 IMO you should |
|
@dmtrjsg |
|
@eshark9312 #4643 is almost ready, so as soon as it gets merged into |
| justify-items: start; | ||
| justify-items: start; | ||
| align-items: center; | ||
| width: 100%; | ||
| height: ${Sizes.accountHeight}; | ||
| padding: 16px; | ||
| margin: -1px; | ||
| margin: -1px; |
| Object.defineProperties(data, { | ||
| unwrap: { value: () => data }, | ||
| isSome: { value: Object.keys(data).length > 0 }, | ||
| get: { value: (key: AccountId32) => data[encodeAddress(key.toString())] }, |
There was a problem hiding this comment.
Good idea but just to make this a bit more general:
| get: { value: (key: AccountId32) => data[encodeAddress(key.toString())] }, | |
| get: { | |
| value: (key: unknow) => { | |
| switch (key) { | |
| case 'object': | |
| if (key.toRawType?.() === 'AccountId') { | |
| return data[encodeAddress(key.toString())] | |
| } | |
| default: | |
| return data[key.toString()] | |
| } | |
| } | |
| } |
There was a problem hiding this comment.
Great work! The graph looks good, I think we should go with chart.js instead of nivo for the financial dashboard too.
FYI all the nominate buttons will be changed into links to the the Polkadot app to nominate validators. But this should be done in a follow up PR. Also I don't remember what the copy should be.
This PR is blocked by #4404Add Validator Card component
> Design
> Story