-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4330 create validator profile #4428
4330 create validator profile #4428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase #4428 on the latest dev
so you can add a test case for the validator profile creation in the App stories
245f711
to
e5a7543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eshark9312 please add some tests in packages/ui/src/app/App.stories.tsx
.
Just like how there is a "Buy Membership Happy", "Buy Membership Not Enough Fund", and "Buy Membership Tx Failure" there should be one happy case flow and some failure cases.
You can check @IlyaSmiyukha's work in the same file (for the backend registration): https://github.com/Joystream/pioneer/pull/4474/files#diff-7380f0a1250873010f135b13dda41bfe98c692e64e9ec929f2d31598b595e8a5
37b806a
to
73339dd
Compare
cd4bc66
to
64b6ed0
Compare
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/memberships/modals/BuyMembershipModal/BuyMembershipFormModal.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work once again 🙌
I had forgotten to suggest skipping the validator query for until someone claims to be a validator on my last review so I added it in a small commit (especially since I'm not so available rn so going through another review cycle would waste time).
Also I'm merging this on a new validators
branch so feature can still be released while the validator dashboard is getting tested.
So from the top of my head what's left is:
- Validator page responsiveness #4706
-
Adding the dashboard to the app routes and the navigationDone in Validator page responsiveness #4706 ! - The update membership modal
Add section to create membership modal for validator's membership.
Add additional step to create membership transaction modal for binding validator's account to the membership.
> Design
> Story