Added Proposal Grace Period #4478
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrlschwb
added
community-dev
There was a problem hiding this comment.
That's the correct data but the current proposal statistics components are not good enough to show these information in a helpful way.
Also we should not show both gracing period and execution block at the same time. AFAIK when exactExecutionBlock is set the gracing period doesn't matter. So please show only the exactExecutionBlock when it's set and only the gracing period otherwise.
packages/ui/src/proposals/components/ProposalDetails/ProposalDetails.tsx
Outdated
Show resolved
Hide resolved
| if (exactExecutionBlock) { | ||
| return [ | ||
| { | ||
| renderType: 'NumberOfBlocks', | ||
| label: 'Exact Execution Block', | ||
| value: exactExecutionBlock, | ||
| }, | ||
| ] as RenderNode[] | ||
| } |
There was a problem hiding this comment.
Here exactExecutionBlock is not actually a number of blocks but a block height so NumberOfBlocks is not the right component. Instead it should show something like the BlockTime component.
| createdAt?: string | ||
| updates?: ProposalStatusUpdates[] |
There was a problem hiding this comment.
Please remove these 2:
| createdAt?: string | |
| updates?: ProposalStatusUpdates[] |
|
Tested on https://dao-21pwiyi8j-joystream.vercel.app/#/proposals/current ✅ Show grace period duration in time/ block(ex block not specified) ✅ Show Exact Block Number at which proposal executes(ex block 4 307 120) |
According to this issue
The second task Show Exact Block Number at which proposal executes
I thought i could achieve that with
proposal.exactExecutionBlockbut its always undefined for the proposals i've checked out so far