Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚓ Integrate set era payout damping factor proposal #4818

Merged
merged 27 commits into from
Apr 8, 2024
Merged

⚓ Integrate set era payout damping factor proposal #4818

merged 27 commits into from
Apr 8, 2024

Conversation

thesan
Copy link
Member

@thesan thesan commented Mar 26, 2024 •
edited
Loading

Addresses #4819

This PR uses a type patch and schema incompatible with #4816. So it shouldn't be merged yet.

It now includes the changes from #4822, so #4822 should be merged first

@vercel Vercel
Copy link

vercel bot commented Mar 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Apr 8, 2024 9:38am
pioneer-2 ✅ Ready (Inspect) Visit Preview Apr 8, 2024 9:38am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Apr 8, 2024 9:38am

thesan
thesan commented Mar 26, 2024
View reviewed changes
Copy link
Member Author

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ignazio-bovo, @kdembler:

.../proposals/modals/AddNewProposal/components/SpecificParameters/SetEraPayoutDampingFactor.tsx Outdated Show resolved Hide resolved
packages/ui/src/proposals/model/proposalDescriptions.ts Outdated Show resolved Hide resolved
@thesan thesan force-pushed the feature/luxor/reward-curve-proposal branch from d03df08 to 97c2943 Compare March 29, 2024 18:33
@thesan thesan force-pushed the feature/luxor/reward-curve-proposal branch from 97c2943 to dfc0803 Compare March 29, 2024 18:41
@kdembler kdembler mentioned this pull request Apr 2, 2024
Closed
@thesan thesan force-pushed the feature/luxor/reward-curve-proposal branch from dfc0803 to 697f1ca Compare April 2, 2024 18:18
@thesan thesan force-pushed the feature/luxor/reward-curve-proposal branch from 697f1ca to 30fbe31 Compare April 4, 2024 14:28
@thesan thesan mentioned this pull request Apr 5, 2024
Merged
kdembler
kdembler approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@kdembler kdembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdembler kdembler marked this pull request as ready for review April 8, 2024 09:51
@kdembler kdembler merged commit 18ea9c5 into luxor Apr 8, 2024
7 checks passed
@kdembler kdembler deleted the feature/luxor/reward-curve-proposal branch April 8, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdembler kdembler kdembler approved these changes

@ignazio-bovo ignazio-bovo Awaiting requested review from ignazio-bovo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @kdembler