🦊 Metamask integration POC #4835
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kdembler the official snap seems to work now but it still reports an error when connecting. Also I it might have been working before the last release, but I was focussed on this error before realizing that the I reported the issue (with the error message): ChainSafe/metamask-snap-polkadot#231 Going forward:
|
|
@kdembler I now get the However it still doesn't work on FF for me. I get to this screen but nothing happens: |
| local: 'http://127.0.0.1:9933', // TODO: check | ||
| testnet: TESTNET_NODE_HTTP_RPC, | ||
| 'local-mocks': 'http://127.0.0.1:9933', // TODO: check |
| const endpointReducer: Reducer<NetworkEndpoints | undefined, Optional<NetworkEndpoints, 'nodeHttpRpcEndpoint'>> = ( | ||
| _, | ||
| newEndpoints | ||
| ): NetworkEndpoints => ({ | ||
| ...newEndpoints, | ||
| nodeHttpRpcEndpoint: | ||
| newEndpoints.nodeHttpRpcEndpoint ?? | ||
| newEndpoints.nodeRpcEndpoint | ||
| .replace('ws:', 'http:') | ||
| .replace('wss:', 'https:') | ||
| .replace('ws-rpc', 'http-rpc') | ||
| .replace(':9944', ''), | ||
| }) |
There was a problem hiding this comment.
Do we still need this logic after we added HTTP endpoint to config explicitly?
There was a problem hiding this comment.
Actually no but we should make sure that the HTTP endpoints are defined in the environment.
Also the code should get the endpoint from the playground configs (I assumed it wasn't in there so I left the logic but it is in the configs e.g: https://atlas-next.joystream.org/network/config.json).
|
Walletconnect seems to not work for me after this change. When I select the option, I don't get the connect popup |
@kdembler I think this is because the wallet connect project from JSG got verified so it won't work on the preview branches anymore. The popup does appear eventually, but the connection doesn't work and this error appears in the console a bunch: So I changed |
Demo
@chainsafe/polkadot-snapfails on FF for me so the demo only works on Chrome based browsers AFAIK.The demo points at my publish version of the snap, so it only works with Metamask Flask.In the meantime it works with a simple text replacement hack.Done ✔️