Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more instructive error message on attempts to parse unsupported file formats #31

Open
michaelosthege opened this issue Dec 1, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@michaelosthege
Copy link
Member

michaelosthege commented Dec 1, 2022

We have a test file that is a CSV exported from the BioLection, which is not supported by bletl.parse.

As per user feedback, attempts to parse such files should give more informative error messages.

We already have a test that can be extended to match a more informative error message:

bletl/tests/test_core.py

Lines 83 to 86 in 5fc74b3

def test_fail_on_unsupported(self):
with pytest.raises(ValueError):
bletl.get_parser(not_a_bl_file)
return

@michaelosthege michaelosthege added the good first issue Good for newcomers label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant