Refactor ordering workaround to fix multi-peak models #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem in the gradient of our previous workaround. Also, the previous workaround unnecessarily introduced a `Normal` just so we could apply the ordered transform. The minor version number was increased, because this changes the structure of multi-peak models.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
At least one of the following two applies:
|
|
I have read the CLA Document and I hereby sign the CLA. |
michaelosthege
added
enhancement
Co-authored-by: Jochen Nießer <j.niesser@fz-juelich.de>
Y0dler
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the gradient of our previous workaround.
Also, the previous workaround unnecessarily introduced a
Normaljust so we could apply the ordered transform.The minor version number was increased, because
this changes the structure of multi-peak models.