Reparametrize double- and multi-peak models #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parametrize double-peak models by "separation"with a Gamma prior. * Keep using ZeroSumNormal for >2 peaks. * Rename `diff`→`offset`. * Reduce the prior for double-peak std by 1/2. Co-authored-by: Jochen Nießer<j.niesser@fz-juelich.de>
Co-authored-by: Jochen Nießer<j.niesser@fz-juelich.de>
michaelosthege
added
enhancement
Y0dler
approved these changes
May 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring was ultimately motivated by the breaking of our ordered-transform workaround (see #8).
It made the tests unreliable, because the ordering of peak means was no longer 100 % strict.
This PR refactors the double-and multi-peak models such that ordered transform (and ZeroSumNormal) no longer play a role for double-peaks.
diff→offset.