Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axes for transposed OffsetArray vector incorrect due to LinearAlgebra method #339

Open
BioTurboNick opened this issue Dec 2, 2023 · 2 comments
Open

Axes for transposed OffsetArray vector incorrect due to LinearAlgebra method #339

BioTurboNick opened this issue Dec 2, 2023 · 2 comments

Comments

@BioTurboNick
Copy link

Just opening this to track the underlying Julia issue: JuliaLang/julia#52373
@BioTurboNick
Copy link
Author

Okay, so I suppose it's a bit bigger than that. Julia Base's issue is assuming that a transposed array will always have a 1-indexed first dimension. And it's true that OffsetArrays assumes that all nonspecified dimensions have the range 1:1.

I suppose my suggestion is that all unspecified dimensions should have a 0:0 range. But that would probably be considered breaking. So I'm open to other thoughts.

@BioTurboNick
Copy link
Author

BioTurboNick commented Dec 3, 2023 •
edited
Loading

At a minimum, it would be nice if centered could produce an object that was centered along all dimensions. Its docstring does suggest that is the intended outcome.

This was referenced Dec 3, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@BioTurboNick