Annotate docstring arguments with types in Filters #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #552 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 18 18
Lines 3202 3201 -1
==========================================
- Hits 3130 3129 -1
Misses 72 72 ☔ View full report in Codecov by Sentry. |
s-celles
reviewed
Mar 2, 2024
src/dspbase.jl
Outdated
| @@ -5,10 +5,12 @@ const SMALL_FILT_CUTOFF = 58 | |||
| _zerosi(b,a,T) = zeros(promote_type(eltype(b), eltype(a), T), max(length(a), length(b))-1) | |||
|
|
|||
| """ | |||
| filt(b, a, x, [si]) | |||
| filt(b::Union{AbstractVector,Number}, a::Union{AbstractVector,Number}, x, [si]) | |||
There was a problem hiding this comment.
it's a bit fat now, though...
wheeheee
force-pushed
the
annotate_types
branch
2 times, most recently
from
c5e63aa
to
13f972d
Compare
|
Merge? |
|
Mostly documentation, so it should be safe, but still needs an approval to merge |
|
For obvious PRs, there is the button on "Merge without waiting for requirements to be met". I would recommend using it for various docs and maintenance PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some concerns in #548 and implements the type restriction in #367.