MySQL test #8
MySQL test #8
Conversation
fixing the file path issue by identifying its type to String - testing it(Passed)
removed .vscode folder added
| prettyurls = get(ENV, "CI", "false") == "true", | ||
| canonical = "https://github.com/JuliaDatabases/DBConnector.jl" | ||
| edit_link = "dev", | ||
| footer = "Created by [Jacob Zelko](https://jacobzelko.com) & [Georgia Tech Research Institute](https://www.gtri.gatech.edu). [License](https://github.com/JuliaHealth/OMOPCDMCohortCreator.jl/blob/main/LICENSE)" |
There was a problem hiding this comment.
You can remove the footer variable here.
| @@ -5,3 +5,6 @@ Example Julia package repo. | |||
| ```@autodocs | |||
There was a problem hiding this comment.
Fareeda, could you open an issue about needing to update the home page of DBConnector.jl's documentation? Thanks!
test/runtests.jl
Outdated
| @testset "_dbconnect function for MySQL" begin | ||
|
|
||
| conn = _dbconnect(MySQL.Connection, "localhost", "debian-sys-maint","HGGsOLypO2LVqq1v", db="mydatabase", port=3306, unix_socket="/var/run/mysqld/mysqld.sock") | ||
| @test typeof(conn) == MySQL.Connection | ||
| @test isopen(conn) | ||
| close(conn) | ||
|
|
||
| end |
There was a problem hiding this comment.
This is very great that this is working! Like you said, we'll need to determine how to run these tests somewhere else. I'd like to somehow get this connection made to the GSoC Server for testing over the summer while somehow maintaining secrecy for our server credentials. Let's talk about this at our weekly check-in!
| makedocs(modules = [Example], sitename = "Example.jl") | ||
| makedocs(; | ||
| modules = [DBConnector], | ||
| authors = "Jacob Zelko (aka TheCedarPrince) <jacobszelko@gmail.com> and Fareeda", |
There was a problem hiding this comment.
Feel free to also add your last name and email too! :D
|
|
||
| deploydocs(repo = "github.com/quinnj/Example.jl.git", push_preview = true) | ||
| ) | ||
| deploydocs(repo = "github.com/quinnj/Example.jl.git", |
There was a problem hiding this comment.
Oh could you update this to the repo URL as shown above? Don't forget the .git extension that needs to be there. Thanks!
docs/src/Functions.md
Outdated
There was a problem hiding this comment.
I am holding off on reviewing this documentation until we chat about tests and further about the API!
| @@ -1,5 +1,8 @@ | |||
| function _dbconnect(conn_obj::Type{MySQL.Connection}, kwargs) | |||
| function _dbconnect(conn_obj::Type{MySQL.Connection}, host::String, user::String, password::String; db::String="", port::Integer=3306, unix_socket::Union{Nothing,String}=nothing, client_flag=API.CLIENT_MULTI_STATEMENTS, opts = Dict()) | |||
There was a problem hiding this comment.
Hm, I am not too sure on this layout here; I think it would be better to have the second argument actually only be a string that is passed to the connection. Let's discuss during our check-in.
-I edited the function, added the exact arguments to be needed
-created test set but those information are from my mysql server, should I change the host to my ip_address?
For issue #2