Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement load_function kwarg for collect_results! #424

Merged

Commits on Aug 23, 2024

  1. implement load_function kwarg for collect_results!

    The changes in this branch are a follow up from a previous pull request
    based on commit 6e6ff07 in PR JuliaDynamics#421. In that PR there were issues
    with whitespace changes inadvertantly coming from the autoformatter
    in vscode. Reverting the whitespace only changes proved to be more
    difficult than anticicpated.
    
    So to resolve this, this branch was created and a new PR will be created
    from it. The whitespace issues are gone but all the feedback and changes
    from the original PR are retained.
    
    The commit makes the following changes.
     - add the `load_function` kwarg to `collect_results`. This allows
    customizing how data is loaded from file before being processed into a
    dataframe by `collect_results`.
     - add a test to `update_result_tests.jl`
     - update docstring of `collect_results`
     - increase package version to 2.16.0
     - update `CHANGELOG.md`
    
    All tests passed, 589 of 589.
    NuclearPowerNerd committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ba1ec2e View commit details
    Browse the repository at this point in the history