Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enzyme: adapt to pending version breaking update #2490

Merged
merged 10 commits into from
Sep 22, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Sep 16, 2024

No description provided.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use [only downstream].

@maleadt maleadt added the extensions Stuff about package extensions. label Sep 18, 2024
@maleadt maleadt marked this pull request as draft September 18, 2024 08:35
@wsmoses wsmoses marked this pull request as ready for review September 18, 2024 19:06
@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 18, 2024

@maleadt okay corresponding Enzyme version has been released

@maleadt
Copy link
Member

maleadt commented Sep 18, 2024

Enzyme.jl tests didn't run here because of the LLVM.jl v9.1 blacklist, so this PR was not tested.

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 18, 2024

ah right.... okay I'll see if I can quickly fix that

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 18, 2024

we've now released a 9.1 compatible version

@wsmoses wsmoses closed this Sep 18, 2024
@wsmoses wsmoses reopened this Sep 18, 2024
@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 19, 2024

@maleadt @vchuravy CI seems to complain with a chicken and egg problem.

So at this point enzyme has compat with all the latest llvm and GPUCompiler and ought be compatible with enzyme……but can’t be solved by pkg due to KA. But the KA pkg testing requirea cuda to accept the enzyme bump which means this has to have already gone in for KA to bump, and so on

@maleadt
Copy link
Member

maleadt commented Sep 19, 2024

CI testing can/should use master branches. And I'm fine being the first one to merge if you have verified this locally.

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 19, 2024

so @maleadt I think this was broken by #2472 in a way that I don't quite understand how to fix?

@maleadt
Copy link
Member

maleadt commented Sep 20, 2024

You'll have to elaborate what the problem is; I'm not familiar with Enzyme.jl (and by extension any of the code in this PR). #2472 simply added a kwarg to the kernel's call method indicating if it should call cudaconvert or not. It uses a Val instead of a simple boolean because it uses the value as part of the @generator; defaulting to true for HostKernels and to false for DeviceKernels.

@wsmoses
Copy link
Contributor Author

wsmoses commented Sep 21, 2024

@maleadt okay this now passes locally on cyclops, if this can get a merge then tag

wsmoses referenced this pull request in JuliaGPU/KernelAbstractions.jl Sep 21, 2024
Adapt to pending Enzymecore changes
@maleadt maleadt merged commit 3b05baf into JuliaGPU:master Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Stuff about package extensions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants