Allow set_point! to work for e.g. StaticArrays and Point2f, and fix Float32 examples for many cases
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loat64 for triangle areas
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 93.49% 93.44% -0.05%
==========================================
Files 73 73
Lines 5439 5450 +11
==========================================
+ Hits 5085 5093 +8
- Misses 354 357 +3
☔ View full report in Codecov by Sentry. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_point!was fixed by just changing the general vector methods, and specialising theVectorcase.The
Float32examples were fixed by just changing how thetriangle_areais computed: The original formula is used, and then if it is not positive try another accurate formula. Moreover, we now convert toFloat64to that onlyFloat64are used in these computations. This fixes #72. Will need to address #73 soon.