Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass input types to mesh #186

Closed
wants to merge 1 commit into from
Closed

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 10, 2023

For MakieOrg/Makie.jl#2573

Adjusts mesh generating functions to keep the input element type around, rather than converting to Float32

@SimonDanisch
Copy link
Member

So, these kind of methods were written specifically to convert to OpenGL datatypes by default.
If one doesn't want them, the mesh should just be created with mesh(...) or Mesh(...) directly...

@ffreyer
Copy link
Collaborator Author

ffreyer commented Jan 10, 2023

Sounds like they should be gl_normal_mesh etc then... But I can also change the default conversions in Makie I guess

@ffreyer ffreyer closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants