update auto-generated code to GLib 2.76 and GTK 4.10 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now based on GLib 2.76 and GTK4 4.10
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 84.72% 85.08% +0.36%
==========================================
Files 43 43
Lines 4372 4386 +14
==========================================
+ Hits 3704 3732 +28
+ Misses 668 654 -14
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The sporadic segfaults that have been happening lately appear to involve dialogs being finalized after their parent window. Add a sleep to try to make sure they are destroyed first.
… window prevents the crash for me locally. This does not solve the underlying issue, which seems like some reference counting bug, since it seems like GtkDialog should hold a reference to the window that would prevent it from being destroyed too early. Are we unreferencing it too many times?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to use the new dialogs in 4.10. Deprecated stuff in GTK 4.10 is still supported.
This also fixes a sporadic segfault in the tests that happens when a
GtkDialogis freed before its parentGtkWindow. I have never seen this happen outside the tests, but it's probably worth creating an issue about it.