save_dialog and open_dialog breaks when called by buttons

[ChantalJuntao]

While save_dialog() and open_dialog work fine when called from the command line, they break when called by a button.

using GtkObservables, Gtk4

c = canvas(UserUnit)
win = GtkWindow(c)

function saveme(window)
    @show "saving"
    name = save_dialog("Choose file", window)
    @show name
end

savebutton = button("save"; widget=nothing, observable=nothing)
sbox = GtkBox(:v)
push!(sbox, savebutton)
push!(win, sbox) #this is a stupid location to put this button
GtkObservables.gc_preserve(win, savebutton)
savesignal = on(savebutton) do _
    @show "click"
    saveme(win);
end

After clicking:

julia> "click" = "click"
"saving" = "saving"


<julia freezes and crashes>

[jwahlstrand]

When you use the dialog functions in a callback you have to use the method that takes a function callback (or the do syntax). This should probably be more prominent in the documentation:

https://juliagtk.github.io/Gtk4.jl/dev/manual/dialogs/#File-Dialogs

I'll make them clearer.

The following works for me:

using GtkObservables, Gtk4

c = canvas(UserUnit)
win = GtkWindow(c)

function saveme(window)
    @show "saving"
    save_dialog("Choose file", window) do name
        @show name
    end
end

savebutton = button("save"; widget=nothing, observable=nothing)
sbox = GtkBox(:v)
push!(sbox, savebutton)
push!(win, sbox) #this is a stupid location to put this button
GtkObservables.gc_preserve(win, savebutton)
savesignal = on(savebutton) do _
    @show "click"
    saveme(win);
end

[jwahlstrand]

Added a couple of notes to the dialogs docs: https://juliagtk.github.io/Gtk4.jl/dev/manual/dialogs/