GtkTextView: use pointer or Ref instead of _GtkTextIter struct (breaking) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with everything else in the package
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v7 #62 +/- ##
=====================================
Coverage ? 82.03%
=====================================
Files ? 44
Lines ? 4842
Branches ? 0
=====================================
Hits ? 3972
Misses ? 870
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Merged
jwahlstrand
added a commit
that referenced
this pull request
Sep 21, 2024
* require julia 1.10 * minor stuff * improve test coverage (#70) * Use new dialogs (breaking) (#49) In the newer versions of GTK v4, new dialogs were introduced and the old ones were deprecated, including GtkDialog and GtkMessageDialog. There isn't much difference in user-facing behavior, but since the old ones were deprecated it's less likely bugs will be fixed. This PR migrates to the new dialogs and cleans up our API a little. I left the file dialogs alone after looking in the C code and realizing that the new dialogs are based on GtkFileChooserNative, like the old code. * GtkTextView: use pointer or Ref instead of _GtkTextIter struct (breaking) (#62) * GtkTextView: use pointer or ref instead of _GtkTextIter struct This is more consistent with everything else in the package * random stuff * support adding widgets to gutter * fix GtkTextIter auto-generated methods, better support methods for all non-opaque structs * a bit of tidying * remove unneeded version check * add simple TextView example * update auto-generated code for Adwaita * simplify generation script for Adwaita * update auto-generated code * regenerate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct
_GtkTextIteris not opaque, but users of this package are never going to want to modify its fields, which are literally all named "dummy". It makes way more sense to pass pointers and references to it than the struct itself, and it's more consistent with everything else in this package. Both GtkTextView and GtkTreeView sort of fell through the cracks when I was sorting out major issues back around version 0.3.One could do the same thing with GtkTreeView and
_GtkTreeIter, but that API is deprecated in recent versions of GTK4 and its functionality can be replaced with GtkListView, etc. So I am strongly inclined to leave it alone.