Convert H5Z*.jl packages into package extensions #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea: it would be much simpler to maintain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The H5Z*.jl packages such as H5Zblosc.jl implement HDF5 filter plugins.
These were written before the advent of package extensions in Julia 1.9.
This pull request converts the implementations of the H5Z*.jl packages
into package extensions. The H5Z*.jl packages are transitional packages
that are shells of their former selves. They only serve two purposes:
After this pull request loading the H5Z*.jl packages could be replaced
by loading the weak dependency directly. For example H5Zblosc.jl could
be replaced by loading Blosc.jl. Another example is that H5Zlz4.jl
could be replaced by loading CodecLZ4.jl.
Exporting the filter could be provided by leaving a function stub
with no methods in HDF5.jl. For example,
function BloscFilter endcould be declared in HDF5.jl and then implemented in the package
extensions.