Fix H5Zzstd error reporting and decompressed size behavior #1151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaIO/JLD2.jl#560 revealed that error reporting was not occuring when there were errors present.
ZSTD_getDecompressedSize
can result in an error, resulting in a return value of 0.Libc.malloc(0)
may not return a null pointer.Therefore we need to check the return value of
ZSTD_getDecompressedSize
directly beforetrying to malloc.
Also improve error handing overall.