Fix error when trying to store instances of <: Function types

JuliaIO · Sep 20, 2024 · be2b913 · be2b913
1 parent b54623f
commit be2b913
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/data/writing_datatypes.jl b/src/data/writing_datatypes.jl
@@ -445,7 +445,7 @@ end
 
 function h5convert!(out::Pointers, ::DataTypeODR, f::JLDFile, T::DataType, wsession::JLDWriteSession)
     t = typename(T)
-    if T <: Function && isgensym(nameof(T.instance))
+    if T <: Function && isgensym(Symbol(T))
         @warn LazyString("Attempting to store ", T, ".\n",
                          "JLD2 only stores functions by name.\n",
                          " This may not be useful for anonymous functions.")

diff --git a/test/loadsave.jl b/test/loadsave.jl
@@ -788,4 +788,16 @@ if VERSION ≥ v"1.7"
         f = x -> x+1
         @test_warn contains("Attempting to store") save_object(fn, f)
     end
-end
+end
+
+struct Foo601 <: Function
+    x::Int
+end
+
+@testset "Issue #601: Storing <: Function objects" begin
+    foo = Foo601(2)
+    tempfile = tempname()
+    jldsave(tempfile; foo)
+    loaded_foo = load(tempfile, "foo")
+    @test loaded_foo isa Foo601
+end