-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Accepting already open and limited IO types #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 85.21% 85.45% +0.23%
==========================================
Files 36 37 +1
Lines 4391 4406 +15
==========================================
+ Hits 3742 3765 +23
+ Misses 649 641 -8 ☔ View full report in Codecov by Sentry. |
JonasIsensee
force-pushed
the
betterio
branch
2 times, most recently
from
September 19, 2024 07:28
8da9bf9
to
526e471
Compare
JonasIsensee
force-pushed
the
betterio
branch
from
September 19, 2024 07:59
526e471
to
ec87ed5
Compare
JonasIsensee
force-pushed
the
betterio
branch
2 times, most recently
from
October 6, 2024 18:36
3d98bd4
to
ba75c32
Compare
This was referenced Oct 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method
jldopen(::IO, mode; kwargs...)
that should take in already opened IOs and figure out what to do with them.
Currently, this PR implements a
ReadOnlyBuffer
that can wrap anotherIO
object which only supports reading but not seeking. Therefore it reads linearly and buffers everything in between.JLDFile
Referencing
#346
#233
#304