Compatibility with IntervalArithmetic v0.22 #203
Conversation
|
With the update to the doc, this PR is not fully ready for review. |
|
Ok! I can help with the review once you decide your PR is ready. |
@Kolaru was the "not" a "now" with a typo? :) |
|
Yes I believe that was the case 🙂 |
src/roots.jl
Outdated
| reltol::T # TODO | ||
| max_iteration::Int # TODO |
There was a problem hiding this comment.
What is the meaning of "TODO"?
There was a problem hiding this comment.
They options are straight up not used currently 😬.
I've moved this to the docstrings.
|
I went through the changes. Since I am not familiar with this library, I cannot comment on the some inner changes, but in terms of IA v0.22, it is looking good! I think the breaking changes are consistent with IA changes, so it may be good to merge this PR soon-ish. |
|
Thanks a lot ! I have added two missing docstrings. I will go through the doc to make sure everything is described, and then I think it would be indeed ready to be merged. |
|
Surprising myself, I had already updated the doc and added an entry in NEWS.md, so I am merging. |
This PR aims at providing compatibility with IntervalArithmetic v0.22, which is breaking.
The user facing changes are
Intervalin the latest releases of IntervalArithmetic)rootsfunction changed toroots(f::Function, X::Union{Interval, AbstractVector} ; kwargs...), with the following consequencesrootsfunction.IntervalBox. Multidimensional problem are specified by returning a vector of intervals, and giving a vector of intervals as initial search region.rootsfunction are unsupported for the time being (e.g.Slopesand quadratic equations). If you were using them, please open an issue.rootsworks with@exact.This PR does not yet contain an update of the documentation, but is otherwise ready for review (if the tests pass on CI ^^').