fix inference of PackageSpec constructor in presence of imprecise inp…

…ut types (#3585) (cherry picked from commit 8d83d53)
JuliaLang · Aug 18, 2023 · b7368c0 · b7368c0
1 parent a80b3c9
commit b7368c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Types.jl b/src/Types.jl
@@ -116,10 +116,10 @@ function PackageSpec(; name::Union{Nothing,AbstractString} = nothing,
     uuid = uuid === nothing ? nothing : UUID(uuid)
     return PackageSpec(name, uuid, version, tree_hash, repo, path, pinned, url, rev, subdir)
 end
-PackageSpec(name::AbstractString) = PackageSpec(;name=name)
-PackageSpec(name::AbstractString, uuid::UUID) = PackageSpec(;name=name, uuid=uuid)
-PackageSpec(name::AbstractString, version::VersionTypes) = PackageSpec(;name=name, version=version)
-PackageSpec(n::AbstractString, u::UUID, v::VersionTypes) = PackageSpec(;name=n, uuid=u, version=v)
+PackageSpec(name::AbstractString) = PackageSpec(;name=name)::PackageSpec
+PackageSpec(name::AbstractString, uuid::UUID) = PackageSpec(;name=name, uuid=uuid)::PackageSpec
+PackageSpec(name::AbstractString, version::VersionTypes) = PackageSpec(;name=name, version=version)::PackageSpec
+PackageSpec(n::AbstractString, u::UUID, v::VersionTypes) = PackageSpec(;name=n, uuid=u, version=v)::PackageSpec
 
 function Base.:(==)(a::PackageSpec, b::PackageSpec)
     return a.name == b.name && a.uuid == b.uuid && a.version == b.version &&

diff --git a/test/misc.jl b/test/misc.jl
@@ -25,4 +25,6 @@ end
     end
 end
 
+@test eltype([PackageSpec(a) for a in []]) == PackageSpec
+
 end # module