Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how public API is defined (depends on scoped export) #3511

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

LilithHafner
Copy link
Member

This PR is an extension of JuliaLang/julia#50105 and should be merged or closed simultaneously.

The key sentence is

Unless you note otherwise, the public API of your package is defined as all the behavior you
describe about exported symbols

And the reason this definition is viable is that scoped exports allow you to export symbols without the namespace implications.

@fredrikekre fredrikekre marked this pull request as draft June 8, 2023 14:21
@KristofferC
Copy link
Member

In general I think things like this are better off in the Julia manual. In some sense, Pkg is "just" a package manager and someone could in theory write another better one. And we should IMO then try to keep the documentation to package management and less about general julia package information. I realize that things are pretty muddy now (for example the extension documentation is in Pkg, which it probably shouldn't be), but I think it is something to strive for.

Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
@c42f
Copy link
Member

c42f commented Aug 10, 2023

Agree @KristofferC that this stuff would be better in the Julia manual. The issue as I see it, is that the manual has no place for tutorial-style docs.

So how about we just merge this here for now alongside the extensions stuff? Because it's strictly better to have this documented somewhere rather than sitting in a stale PR :)

@KristofferC
Copy link
Member

KristofferC commented Aug 28, 2023

So how about we just merge this here for now alongside the extensions stuff? Because it's strictly better to have this documented somewhere rather than sitting in a stale PR :)

I mean, we don't even have public in Base so it feels kind of premature to merge the doc change before the feature itself even exists.

@LilithHafner
Copy link
Member Author

I think "merge this here for now" means at the same time as the public keyword merges in Base

@LilithHafner LilithHafner marked this pull request as ready for review September 14, 2023 19:54
@LilithHafner LilithHafner merged commit da8bae7 into master Sep 14, 2023
13 checks passed
@LilithHafner LilithHafner deleted the LilithHafner-patch-2 branch September 14, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants