Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompilation: capture stdout as well as stderr #3573

Merged
merged 5 commits into from
Aug 15, 2023
Merged

precompilation: capture stdout as well as stderr #3573

merged 5 commits into from
Aug 15, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Aug 9, 2023 •
edited
Loading

Fixes #3548

@vtjnash in particular is the use of a single BufferStream iob ok here or should it use two buffers?

@IanButterworth
Copy link
Member Author

Another question is whether we should just do this always and not just code load

vtjnash
vtjnash reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strongly forbidden for the same object to be used asynchronously in two difference places.

vtjnash
vtjnash reviewed Aug 9, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using a Pipe(). There also should not be a close(iob) call, ever, since that corrupts the stream.

IanButterworth
IanButterworth commented Aug 11, 2023
View reviewed changes
src/API.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth changed the title precompilation: capture stdout during code load precomp precompilation: capture stdout as well as stderr Aug 11, 2023
@IanButterworth IanButterworth mentioned this pull request Aug 11, 2023
Closed
@IanButterworth IanButterworth self-assigned this Aug 12, 2023
vtjnash
vtjnash reviewed Aug 14, 2023
View reviewed changes
src/API.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Aug 14, 2023
View reviewed changes
src/API.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Aug 14, 2023
View reviewed changes
src/API.jl Outdated Show resolved Hide resolved
src/API.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Aug 15, 2023
View reviewed changes
src/API.jl Show resolved Hide resolved
@IanButterworth IanButterworth merged commit 0a4fb55 into JuliaLang:master Aug 15, 2023
12 of 13 checks passed
@IanButterworth IanButterworth deleted the ib/precomp_capture_stdout branch August 15, 2023 14:46
@IanButterworth IanButterworth mentioned this pull request Aug 16, 2023
Closed
IanButterworth added a commit that referenced this pull request Aug 18, 2023
@IanButterworth
precompilation: capture stdout as well as stderr (#3573)
2bbb774 
(cherry picked from commit 0a4fb55)
@IanButterworth IanButterworth mentioned this pull request Aug 18, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

@IanButterworth IanButterworth

Labels
precompile Pkg.precompile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdout messages lost by precompile [regression]
2 participants
@IanButterworth @vtjnash