status: expand 2 symbol upgrade note to highlight *may* be upgradable #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2023
Merged
Merged
5 tasks
IanButterworth
force-pushed
the
ib/status_upgrade_msg
branch
from
6605b60
to
aee66f8
Compare
IanButterworth
force-pushed
the
ib/status_upgrade_msg
branch
from
aee66f8
to
7d6834b
Compare
IanButterworth
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Now just a slight tweak to the original message to avoid duplication.
The combined Info tip skipped the key word "may" in
may be upgradablewhich has been a common source of confusion.I think it might just be better to show each tip individually if both symbols are present?
Before
This PR
