Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile: if a single package is requested, show output live #3582

Merged

Conversation

IanButterworth
Copy link
Member

Fixes #3487

@vtjnash something like this, perhaps?

Screenshot 2023-08-11 at 9 04 01 PM Screenshot 2023-08-11 at 9 04 32 PM

@IanButterworth
Copy link
Member Author

An alternative would be for code loading precompilation to parallel precomp all of the depdendencies but leave off the requested package, then exit and leave the old serial precompilation to finish the main package like it used to.
Though it would look a bit like a bug if it did that, I think.

src/API.jl Outdated Show resolved Hide resolved
@vtjnash
Copy link
Member

vtjnash commented Aug 14, 2023

Seems useful, but also a bit odd to see the output repeated twice. I like the concept of having output appear as each task finishes for each process. For comparison, in gmake, this would correspond to the --output-sync={none,line,target,recurse} options, of which my preferred is usually target and that is also the default. Currently we instead implement the equivalent of recurse only.

@IanButterworth
Copy link
Member Author

Updated to
Screenshot 2023-08-14 at 10 09 16 PM

Note that now if you call precompile in a package project, it will follow this behavior too.

@IanButterworth
Copy link
Member Author

I like the concept of having output appear as each task finishes for each process.

It's an interesting idea, but would be a bigger change with some tricky UX because of the way packages disappear when done. This PR is a bit more manageable in UX because it only happens to the last singular package being precompiled.

@IanButterworth
Copy link
Member Author

Marking this for 1.10 backport because the reported issue was introduced by code load parallel precompile which was introduced in 1.10

@IanButterworth
Copy link
Member Author

Let's get this on master to get it tried out

@IanButterworth IanButterworth merged commit 08e1eb6 into JuliaLang:master Aug 16, 2023
11 of 13 checks passed
@IanButterworth IanButterworth deleted the ib/precompile_show_live branch August 16, 2023 20:09
IanButterworth added a commit that referenced this pull request Aug 18, 2023
@IanButterworth IanButterworth mentioned this pull request Aug 18, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precompile Pkg.precompile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show output for explicitly precompiled packages immediately
2 participants