docs: add manifest field documentation to Project.toml guide in Pkg.jl manual
#3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….jl manual This should be mentioned here. Added in: JuliaLang#3579
mortenpi
reviewed
Nov 15, 2023
|
|
||
| This specified `Manifest.toml` does not need to be a subset of the project's own manifest. | ||
| The project inherits any version constraints or package specifications from the referenced manifest and is integrated into the dependency resolution process. | ||
|
|
There was a problem hiding this comment.
Needs a compat note I think. I hope this is accurate:
Suggested change
| !!! compat "Julia 1.11" | |
| This feature requires at least Julia 1.11. On earlier Julia version, the `manifest` entry in the `Project.toml` file gets ignored. |
lassepe
reviewed
Dec 22, 2023
| manifest = "../Manifest.toml" | ||
| ``` | ||
|
|
||
| This specified `Manifest.toml` does not need to be a subset of the project's own manifest. |
There was a problem hiding this comment.
I think the wording "subset" here is unclear.
There was a problem hiding this comment.
Yes, I'm not sure this is correct behavior. I'm somewhat exercising Cunningham's law here to get critique on what is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be mentioned here.
Added in: #3579